MozillaZine

[Ext] Add Bookmark Here ²

Announce and Discuss the Latest Theme and Extension Releases.
yuoo2k

User avatar
 
Posts: 721
Joined: November 1st, 2005, 9:03 am
Location: Taiwan

Post Posted June 18th, 2016, 3:56 am

phkhgh wrote:Hello yuoo2k,
As mentioned, the "Cancel" button is now missing from ABH2's UI, in Fx 47.0 final (Windows).
I'm using ABH 41.0.20160423 (automatically updated).

Really, if you hit Esc WHILE ABH pop up window is active window, ABH probably shouldn't just stick the bookmark in the "Bookmarks Menu" folder.
When it still had a cancel button, that was still the behavior if hit Esc instead of Cancel. Generally, if you escape out of a menu / screen, you don't want changes saved.
Is there any reason why that would be (is) different in ABH?

Are you using a firefox api for the add bookmark popup menu & tweaking it? Did they remove cancel button, or did you?

It's not the end of world, but cleaning the Bookmarks Menu folder is one more thing to do.

Thanks.

You can refer to this Bugzilla ticket which causes the changes you mentioned:
https://bugzilla.mozilla.org/show_bug.cgi?id=1219794

yuoo2k

User avatar
 
Posts: 721
Joined: November 1st, 2005, 9:03 am
Location: Taiwan

Post Posted June 18th, 2016, 4:42 am

Magnus21 wrote:I want to bookmarked page always go in Unsorted bookmarks category, without any question or additional settings, like in prevoius versions of FF. So, I want next > when I click on the Star bookmarked page go directly to Unsorted bookmarks category, at the bottom of that category.

I find [Ext] Add Bookmark Here ², there is an option that I need, but bookmarked page go up to the unsorted category or in a selected folder in that category. Therefore, if there is an option to bookmarked page go at the bottom of unsorted bookmarks?

Yes, try to uncheck "Insert to the Top" from ABH2 Option dialog [Main] tab:
1.Right click on STAR to open ABH2 options.
2.[Main] tab -> Uncheck "Insert to the Top".
3.[Advanced] tab -> Check "Add to Unsorted Bookmarks Folder" and "Customize Unsorted Bookmarks Folder".

yuoo2k

User avatar
 
Posts: 721
Joined: November 1st, 2005, 9:03 am
Location: Taiwan

Post Posted June 28th, 2016, 11:13 pm

phkhgh wrote:the "Cancel" button is now missing from ABH2's UI, in Fx 47.0 final (Windows).

Really, if you hit Esc WHILE ABH pop up window is active window, ABH probably shouldn't just stick the bookmark in the "Bookmarks Menu" folder.
When it still had a cancel button, that was still the behavior if hit Esc instead of Cancel. Generally, if you escape out of a menu / screen, you don't want changes saved.

v47.20160629: https://addons.mozilla.org/en-US/firefo ... /versions/
+ Fixed: Since Firefox 47, we are no longer to CANCEL the changes on Bookmark Dialog. https://bugzilla.mozilla.org/show_bug.cgi?id=1219794

madmudmob

User avatar
 
Posts: 810
Joined: August 30th, 2006, 7:34 am
Location: Somerset, UK

Post Posted July 17th, 2016, 9:58 am

Please can you make this wonderful extension work fully with 47.0.1?

I can't seem to get it to remember where I put the last bookmark when I want the next to go to the same place?
Mud is good!

CelAvg
 
Posts: 4
Joined: December 13th, 2002, 11:51 am

Post Posted July 18th, 2016, 8:28 am

I am sorry, but I ran into a new issue (presumably):

As of now, perhaps connected to shifting to Windows 10, ABH2 when invoked does NOT display any more dialog.
The only thing still working is Mouse right click / Bookmark All. A brief dialog is displayed, and the bookmarks are saved at the location mentioned.
Any other option is gone.
Also, since it is Firefox 47 & Win 10, there is no more: menuedit.rdf at the location mentioned.

I would be very grateful for any solution..

Greetings

yuoo2k

User avatar
 
Posts: 721
Joined: November 1st, 2005, 9:03 am
Location: Taiwan

Post Posted July 18th, 2016, 8:49 am

Would you please try to create a new profile with only ABH2 installed to see if other extension conflict with ABH2.
Thanks.

--
To create a new profile:

Windows:
1. close Firefox.
2. press Win+R, enter: firefox.exe -p

Mac:
1. Cmd+Q, close Firefox.
2. press Control+Space, open Terminal
3. enter: /Applications/Firefox.app/Contents/MacOS/firefox-bin -p

CelAvg
 
Posts: 4
Joined: December 13th, 2002, 11:51 am

Post Posted July 18th, 2016, 8:57 am

yuoo2k wrote:Would you please try to create a new profile with only ABH2 installed to see if other extension conflict with ABH2.
Thanks.

--
To create a new profile:

Windows:
1. close Firefox.
2. press Win+R, enter: firefox.exe -p

Mac:
1. Cmd+Q, close Firefox.
2. press Control+Space, open Terminal
3. enter: /Applications/Firefox.app/Contents/MacOS/firefox-bin -p


Thanks for your reply!
Done, new profile created.
The dialog of ABH2 is displayed as usual...
Now we need to find out which extension could be in conflict....

How to proceed?

DONE!!!

Indeed, there was an outdated extension in charge....

Thanks for your hint!

madmudmob

User avatar
 
Posts: 810
Joined: August 30th, 2006, 7:34 am
Location: Somerset, UK

Post Posted July 29th, 2016, 11:18 am

Is there any way to hide Add Bookmark Here to the right click context menu in the drop down list of bookmarks (the one next to the bookmark star) please?

I have Stylish installed but can not seem to find a way to hide it.

Any and all help much appreciated.
Mud is good!

madmudmob

User avatar
 
Posts: 810
Joined: August 30th, 2006, 7:34 am
Location: Somerset, UK

Post Posted July 29th, 2016, 12:54 pm

SORTED :)

I copied another Style and altered the wording and have now removed Add Bookmark Here with this ....

@namespace url(http://www.mozilla.org/keymaster/gateke ... s.only.xul);

menuitem[label="Add Bookmark Here..."] { display: none !important; }
Mud is good!

L.A.R. Grizzly

User avatar
 
Posts: 5349
Joined: March 15th, 2005, 5:32 pm
Location: Akron, Ohio, USA

Post Posted August 7th, 2016, 10:17 am

After updating to FX 48.0, I discovered an extra separator in my Bookmarks Menu. After troubleshooting, I've found that it's a conflict with Aris' CTR. He was able to supply me with a code that blocks the extra separator that ABH² is causing. Below are links to our discussion and the temporary solution:

viewtopic.php?p=14676515#p14676515

viewtopic.php?p=14676551#p14676551

viewtopic.php?p=14676755#p14676755

viewtopic.php?p=14676815#p14676815

viewtopic.php?p=14676821#p14676821

I hope you can look into this for the next release of ABH².
Win7 Pro SP1 64 Bit
Comodo Internet Security
Pale Moon 28.7.1, Interlink Mail 52.9.7176, Firefox 52.9.0esr, Thunderbird 52.9.1 and SeaMonkey 2.48

yuoo2k

User avatar
 
Posts: 721
Joined: November 1st, 2005, 9:03 am
Location: Taiwan

Post Posted August 10th, 2016, 8:28 am

L.A.R. Grizzly wrote:After updating to FX 48.0, I discovered an extra separator in my Bookmarks Menu. After troubleshooting, I've found that it's a conflict with Aris' CTR. He was able to supply me with a code that blocks the extra separator that ABH² is causing.

Hello, thanks for the bug report, please try the new version:
v48.0.20160810: https://addons.mozilla.org/en-US/firefo ... /versions/
+ Fixed: An extra menu separator shows in Bookmarks Menu.
+ Fixed: Rename [Unsorted Bookmarks] to [Other Bookmarks].
+ Added: Options > Menu > Show [View Pocket List].

madmudmob

User avatar
 
Posts: 810
Joined: August 30th, 2006, 7:34 am
Location: Somerset, UK

Post Posted August 10th, 2016, 8:32 am

Firefox won't allow me to install it
Mud is good!

L.A.R. Grizzly

User avatar
 
Posts: 5349
Joined: March 15th, 2005, 5:32 pm
Location: Akron, Ohio, USA

Post Posted August 10th, 2016, 9:46 am

yuoo2k wrote:Hello, thanks for the bug report, please try the new version:
v48.0.20160810: https://addons.mozilla.org/en-US/firefo ... /versions/
+ Fixed: An extra menu separator shows in Bookmarks Menu.
+ Fixed: Rename [Unsorted Bookmarks] to [Other Bookmarks].
+ Added: Options > Menu > Show [View Pocket List].


You're welcome! v48.0.20160810 fixes the extra Bookmark Menu separator on my system. Kudos!
Win7 Pro SP1 64 Bit
Comodo Internet Security
Pale Moon 28.7.1, Interlink Mail 52.9.7176, Firefox 52.9.0esr, Thunderbird 52.9.1 and SeaMonkey 2.48

Jack Black

User avatar
 
Posts: 82
Joined: January 17th, 2011, 2:17 pm

Post Posted August 12th, 2016, 7:13 pm

Here's a few bugs I have on Firefox 48 using the latest version of Add Bookmark Here ²:

  • The "Bookmark this page" dialog doesn't retain its settings (for example if you have expanded the tree) if the Bookmark button (the star) is in the "hamburger" menu or has been removed.
  • The "Bookmark this link" dialog appears at the left of the window, with the arrow misplaced, and doesn't retain its settings (e.g. if the tree has been expanded or not).
  • This bug is tricky (so I have no precise step to reproduce it), as it seems to occur only after customizing Firefox (it disappears if you reset settings to their default, using "Customize... -> Restore Defaults"): at one point, when using "Bookmark this link", the Bookmark dialog won't appear (excerpt from the log: "TypeError: target is null" -- chrome://abhere2/content/browserOverlay.js -- line 137, column 13), even though the bookmark is created "succesfully".

    There's more to that: when going to the page you just bookmarked using "Bookmark this link", and clicking on "modify this bookmark", the bookmark dialog acts as if the page was just marked: the "Remove Bookmark" button isn't there, and clicking on "cancel" deletes the bookmark.

    Considering this bug disappears after restoring the UI to its default state, I may be able to find something useful looking at xulstore.json and at the "browser.uiCustomization.state" preference...


All 3 bugs disappear after disabling Add Bookmark Here ².

yuoo2k

User avatar
 
Posts: 721
Joined: November 1st, 2005, 9:03 am
Location: Taiwan

Post Posted August 13th, 2016, 12:42 pm

Jack Black wrote:
  • The "Bookmark this page" dialog doesn't retain its settings (for example if you have expanded the tree) if the Bookmark button (the star) is in the "hamburger" menu or has been removed.
  • The "Bookmark this link" dialog appears at the left of the window, with the arrow misplaced, and doesn't retain its settings (e.g. if the tree has been expanded or not).
  • This bug is tricky (so I have no precise step to reproduce it), as it seems to occur only after customizing Firefox (it disappears if you reset settings to their default, using "Customize... -> Restore Defaults"): at one point, when using "Bookmark this link", the Bookmark dialog won't appear (excerpt from the log: "TypeError: target is null" -- chrome://abhere2/content/browserOverlay.js -- line 137, column 13), even though the bookmark is created "succesfully".

Hello, try this new version, it should fix above issues.
v48.0.20160813: https://addons.mozilla.org/en-US/firefo ... /versions/
+ Fixed: Bookmark dialog not work well if user remove the STAR button.
+ Fixed: [Bookmark this Link] should popup the dialog that anchor on link.

Return to Extension/Theme Releases


Who is online

Users browsing this forum: No registered users and 1 guest