MozillaZine

[Ext] Classic Theme Restorer

Announce and Discuss the Latest Theme and Extension Releases.
Aris

User avatar
 
Posts: 2867
Joined: February 27th, 2011, 10:14 am

Post Posted March 13th, 2017, 11:45 am

Nothing changed for me with today's Dev/Nightly builds. Even tested both "Compact" themes on a new profile with only CTR installed.

Image
Image

notonymous

User avatar
 
Posts: 135
Joined: November 6th, 2002, 6:57 pm
Location: Beyond the fringe

Post Posted March 13th, 2017, 4:32 pm

Well, that's not what I see with a clean profile and only CTR installed:

Image

Image

The "separator" image is blank in the customisation panel and there should be separators between most of the toolbar icons. There appears to be some spacing so the separator image isn't null.

Aris

User avatar
 
Posts: 2867
Joined: February 27th, 2011, 10:14 am

Post Posted March 14th, 2017, 2:02 am

OK, separator images are only missing using Windows Classic visual style. Next update will offer separators non-classic visual style currently provides as a workaround.

notonymous

User avatar
 
Posts: 135
Joined: November 6th, 2002, 6:57 pm
Location: Beyond the fringe

Post Posted March 14th, 2017, 5:37 am

Aris wrote:OK, separator images are only missing using Windows Classic visual style. Next update will offer separators non-classic visual style currently provides as a workaround.


Terrific, the new beta fixed it :-) Thanks very much.

marty60
 
Posts: 428
Joined: March 21st, 2012, 7:09 am

Post Posted March 14th, 2017, 8:16 am

Hi Aris, where is the setting for Windows Classic visual style, I can't locate it? The reason I ask is because in my Firefox 2 theme all the separators are dark black now so I'd like to change them back.

Aris

User avatar
 
Posts: 2867
Joined: February 27th, 2011, 10:14 am

Post Posted March 14th, 2017, 9:01 am

Sorry, I have not excluded that "fix" from complete themes yet. Next update will solve your issue, but you already can install this dev build on Nightly without waiting for next beta.
Code: Select all
https://www.dropbox.com/s/v7nryrx0npd4yhc/CTR201703141.xpi?dl=0

marty60
 
Posts: 428
Joined: March 21st, 2012, 7:09 am

Post Posted March 14th, 2017, 9:30 am

That build fixed it, the Firefox 2 theme has the old-style separators back. The dark black ones look good in the default theme though, maybe consider an option to toggle between the two or maybe it's already there and I'm missing it?

Aris

User avatar
 
Posts: 2867
Joined: February 27th, 2011, 10:14 am

Post Posted March 15th, 2017, 3:47 am

At the moment there is no option to toggle between different toolbar separators. The current fix "restores" dark and light separators for default, lightweight and "Compact" Firefox themes on Windows XP, Vista and 7 when using "Windows classic visual style". Other cases were not affected by recent Aurora/Nightly changes.

Complete themes still handle separators correctly anyway, right?

neektj
 
Posts: 1
Joined: March 14th, 2017, 11:14 pm

Post Posted March 15th, 2017, 4:37 am

Hey,

First of all - great addon. It's a big shame it won't work post FF57.

I was just wondering how the "Reduce space above toolbar" option is implemented? I tried searching through your code on Github, but couldn't find it (I'm a complete newbie to coding).

Is this option something that will be possible once WebExtensions is enforced? Or would it be possible to do with a Greasemonkey or Stylish script?

Thanks

Aris

User avatar
 
Posts: 2867
Joined: February 27th, 2011, 10:14 am

Post Posted March 15th, 2017, 6:02 am

We do not know how or even if css code will be able to tweak ui in Firefox 57 yet. I guess unpacking, modifying and repacking browser files might work, but that is not something for the majority of users and it also would have to be repeated for every browser update.

The mentioned option just changes margin values (margin-top: ...px) above tabs toolbar in some cases.

marty60
 
Posts: 428
Joined: March 21st, 2012, 7:09 am

Post Posted March 15th, 2017, 7:05 am

Aris wrote:Complete themes still handle separators correctly anyway, right?

Yes, with that fix you posted yesterday both of my complete themes are displaying separators as they previously had.

85rx-7se
 
Posts: 217
Joined: March 10th, 2006, 12:41 pm

Post Posted March 22nd, 2017, 1:35 pm

Aris .. can you please have a look at my post here at the Mozilla Forums ?

viewtopic.php?f=38&t=3028535&p=14739089#p14739089

It has been suggested that perhaps Classic Theme Restorer is causing the issue I see with Bookmarks
that are on the Bookmarks Toolbar ... The problem is only happening on my Dell 8200 XP PRO SP3 computer.
It is not happening on a Toshiba Laptop with Windows 10 Home 64 Bit .. both are running Firefox 47.0.2
and the same set of extensions. The issue I am trying to fix is the square shape around the items on the
bookmarks toolbar.

Image

JayhawksRock

User avatar
 
Posts: 10361
Joined: October 24th, 2010, 8:51 am

Post Posted March 22nd, 2017, 2:01 pm

@85rx-7se

FWIW, I did NOT say CTR is the cause... but implied CTR may have a fix
Good Luck
"Get your facts first, then you can distort them as you please."
~ Mark Twain

Aris

User avatar
 
Posts: 2867
Joined: February 27th, 2011, 10:14 am

Post Posted March 22nd, 2017, 2:45 pm

@85rx-7se
The "square shape" is a feature of Classic Toolbar Buttons add-on and not CTR.

Go to CTBs options page and uncheck classic style for bookmarks toolbar buttons, items & folder options.

Image

I suggest not to combine CTBs custom back forward button icons with CTRs icons+text options. This combination was not meant to be used together as you can see on your screenshot.

Trel
 
Posts: 99
Joined: January 24th, 2004, 6:11 am

Post Posted March 22nd, 2017, 4:47 pm

I'm having a display issue.

Win 7, Firefox Developer Edition 54, CTR 1.6.4 Beta 4

The left most is how it looks now, the right (in irfan view) is how it used to look.
The nav bar got quite skinny.

Image

Return to Extension/Theme Releases


Who is online

Users browsing this forum: No registered users and 1 guest