MozillaZine

[Ext] DblClicker & KillSpinners & FlashStopper & Add-on Tbb

Announce and Discuss the Latest Theme and Extension Releases.
delicacy1
 
Posts: 284
Joined: September 28th, 2016, 11:25 am

Post Posted August 11th, 2017, 4:39 pm

Hi yochaim,

flashstopper needs an improvement on youtube..

Ex:

I go to the address bar & start typing yout.. then select a video i've seen before from my address bar history,
if i then click on a video from the right list, flashstopper stops it by default, When, such deliberate objective clicks
shouldn't require a secondary click to start the video..

Now..:

if i make a search on youtube findbar, & start a video, then click on any video on from the right list of suggested videos,
flashstopper doesnt interferfer & the first click is considered as a desire to play that video.

Why ? maybe because you've made flashstopper not interact with videos users click from the right suggestive list,
probably only when a search has been initiated..... .

Actual goal & improvement:

Any video clicked from that right list shouldn't ever be stopped..
with or without any video search..


Ps: in my bowser setup, i guess i shouldn't install Version 2.4.7b2 ?
I installed Version 1.4.7b1

Elhem Enohpi
 
Posts: 22
Joined: March 19th, 2016, 8:49 am

Post Posted August 12th, 2017, 6:52 am

yochaim wrote:uploaded new flashstopper versions fs-1.4.7b1 fs-e10s-2.4.7b2 to the dev channel on AMO
https://addons.mozilla.org/en-US/firefo ... sions/beta
for improved handling of html5 video.

@Elhem Enohpi this should fix the vimeo issue.


Thanks! It does seem to fix the problem with the Vimeo button needing three clicks. However, it also seems to have the effect that, if media.autoplay.enabled is false, the Vimeo video won't play at all - the same as without Flashstopper installed. The previous version was somehow overriding media.autoplay.enabled I think. This one doesn't, so it has to be set to true.

yochaim
 
Posts: 464
Joined: September 14th, 2009, 9:23 am

Post Posted August 12th, 2017, 10:38 am

hi Elhem Enohpi,

good catch...
this is what i called (see AMO description) Media autoplay blocking integration.
it means that fs will work the same w/wo media.autoplay.enabled=false so you could allow autoplay on sites etc...
(there is also the play context menuitem for covered html5 videos)

uploaded fixed versions to AMO dev channel.
please check it out...

delicacy1
 
Posts: 284
Joined: September 28th, 2016, 11:25 am

Post Posted August 12th, 2017, 11:08 am

in my bowser setup, i guess i shouldn't install Version 2.4.7b2 ?
I installed Version 1.4.7b1

yochaim
 
Posts: 464
Joined: September 14th, 2009, 9:23 am

Post Posted August 12th, 2017, 11:32 am

1.4.7b2 now...
1.x.x are the non multiprocess versions. you should see the 2.x.x as incompatible when in pm.

max2
 
Posts: 231
Joined: September 17th, 2011, 5:37 pm

Post Posted August 12th, 2017, 12:19 pm

Is it a web extension yet or ever become one please? Thanks.

streetwolf

User avatar
 
Posts: 2119
Joined: August 21st, 2011, 8:07 am
Location: NJ (USA)

Post Posted August 12th, 2017, 12:33 pm

max2 wrote:Is it a web extension yet or ever become one please? Thanks.


Yes there is a WE versions. It is called AutoplayStopper and is located in this zip file... http://www.byo.co.il/Download/newversions.zip.

yochaim. Are you going to get AS signed anytime soon for Fx?
Intel Core i7-8700K CPU @ 5GHz | Gigabyte Z370 AORUS Gaming 7 | Corsair 1000W PSU | Corsair H115i v2 CPU Cooler | Corsair 64GB RAM | EVGA GeForce GTX 1080 Ti FTW3 GAMING 11GB | DUAL ASUS PA249Q IPS 24" LCDs | 2-512GB Samsung 960 PRO M.2 | 2TB Seagate | Windows 10 Pro x64 | FIOS 1Gb Internet

yochaim
 
Posts: 464
Joined: September 14th, 2009, 9:23 am

Post Posted August 13th, 2017, 11:42 am

@Elhem Enohpi

it seems media autoplay blocking integration was broken (by mozilla) since FF53, so allowing sites with media.autoplay.enabled=false didn't work... it is fixed with v2.4.7b4 (AMO dev)

@streetwolf

don't think so...

delicacy1
 
Posts: 284
Joined: September 28th, 2016, 11:25 am

Post Posted August 13th, 2017, 11:44 am

yochaim, you've told me nothing about the issue & improvement needed for youtube..

yochaim
 
Posts: 464
Joined: September 14th, 2009, 9:23 am

Post Posted August 13th, 2017, 12:08 pm

delicacy,

i had nothing good to say...
fs is not handling youtube any different than other sites. it's just stops autoplay on any video (using youtube api in this case)
the reason why after you started a video all links (in the same tab) autoplay is because they reuse the same video element.
if you don't play the first video and click on link from the list the play is not synchronous (which would play) so the video will not start.
there are plenty of youtube enhancers out there for you to use or you can change your youtube handler to to work as you wish...

delicacy1
 
Posts: 284
Joined: September 28th, 2016, 11:25 am

Post Posted August 13th, 2017, 12:27 pm

can you advise me an external script or would adding a script from ur side be complicated ?

yochaim
 
Posts: 464
Joined: September 14th, 2009, 9:23 am

Post Posted August 13th, 2017, 1:45 pm

you can do something crude like releasing the video element after some delay, but it could easily break on edge cases...
you can try adding this inside your userhandler (2500 is the delay in ms)
Code: Select all
handlers.add(function handleReleaseYouTube(aElement){
        const document = aElement.ownerDocument, window = document.defaultView;
        if (document.location.hostname.search("\.youtube(-nocookie)?\.com$") != -1)   
            if (aElement instanceof window.HTMLMediaElement) window.setTimeout(() => (aElement.allowPlay = true), 2500);
});

delicacy1
 
Posts: 284
Joined: September 28th, 2016, 11:25 am

Post Posted August 13th, 2017, 2:21 pm

that wouldn't work ((

i still need to put videos on background tabs "flashstopped" ((

can u write a script that intercepts right & left clicks, at every right click, all videos should play..

yochaim
 
Posts: 464
Joined: September 14th, 2009, 9:23 am

Post Posted August 13th, 2017, 2:48 pm

try it first...

delicacy1
 
Posts: 284
Joined: September 28th, 2016, 11:25 am

Post Posted August 13th, 2017, 3:25 pm

you ignored my previous comment & reason why it wouldn't be useful

Return to Extension/Theme Releases


Who is online

Users browsing this forum: No registered users and 2 guests