MozillaZine

Build failure with GTK2

Discussion about official Mozilla Thunderbird builds
©dn

User avatar
 
Posts: 683
Joined: April 20th, 2003, 1:53 pm
Location: GB

Post Posted May 11th, 2003, 10:21 am

just that change wfm (so far)

builds and runs [ make clean 1st because it was gtk 1.x ]

diff sent to mscott
Code: Select all
Index: mail/app/nsMailApp.cpp
===================================================================
RCS file: /cvsroot/mozilla/mail/app/nsMailApp.cpp,v
retrieving revision 1.2
diff -u -3 -p -r1.2 nsMailApp.cpp
--- mail/app/nsMailApp.cpp      16 Apr 2003 01:00:28 -0000      1.2
+++ mail/app/nsMailApp.cpp      11 May 2003 14:53:21 -0000
@@ -51,7 +51,7 @@ int main(int argc, char* argv[])
   return xre_main(argc, argv, appData);
 }

-#ifdef MOZ_WIDGET_GTK
+#if defined(MOZ_WIDGET_GTK) || defined(MOZ_WIDGET_GTK2)
 char* splash_xpm[] = {0};
 #endif

Index: xpfe/bootstrap/nsNativeAppSupportGtk.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpfe/bootstrap/nsNativeAppSupportGtk.cpp,v
retrieving revision 1.13
diff -u -3 -p -r1.13 nsNativeAppSupportGtk.cpp
--- xpfe/bootstrap/nsNativeAppSupportGtk.cpp    24 Apr 2003 06:25:12 -0000
1.13
+++ xpfe/bootstrap/nsNativeAppSupportGtk.cpp    11 May 2003 14:53:21 -0000
@@ -64,7 +64,8 @@ nsSplashScreenGtk::~nsSplashScreenGtk()

 NS_IMETHODIMP nsSplashScreenGtk::Show()
 {
-#ifdef MOZ_PHOENIX
+
+#ifdef MOZ_XUL_APP
   if (!splash_xpm[0])
     return NS_OK;
 #endif


andred

User avatar
 
Posts: 49
Joined: December 24th, 2002, 10:19 am
Location: Sweden

Post Posted May 13th, 2003, 7:47 am

I can confirm that the latest changes proposed fixed compilation with GTK2 for me. Thanks!

mscott

User avatar
 
Posts: 2516
Joined: April 2nd, 2003, 4:10 pm
Location: Thunderbird Research Center, CA

Post Posted May 14th, 2003, 6:10 pm

This patch has been checked into the tree. I now believe you can build thunderbird using gtk2 without applying any of these patches.

Thanks for the help in tracking this down everyone!
Thunderbirds are Go!

Return to Thunderbird Builds


Who is online

Users browsing this forum: No registered users and 4 guests